Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sec patch #27

Merged
merged 15 commits into from
Jan 20, 2023
Merged

fix: sec patch #27

merged 15 commits into from
Jan 20, 2023

Conversation

mfshao
Copy link
Contributor

@mfshao mfshao commented Jan 18, 2023

Jira Ticket: PPS-154

Improvements

  • Add CSP directives in response

Dependency updates

  • Adpoted helmet
  • Adpoted cors

Deployment changes

  • This change will add some CSP and CORS related header to the response that returned from the dashboard services. They should not be interruptive, but each team is encouraged to double check their webpages hosted by dashboard to ensure they still works
  • Because of these CSP directives being added, starting from this version, if anyone what to load remote scripts in their dashboard-hosted webpages, they will need to update the CSP directives in this dashboard service if the current directives doesn't fit, or to ship the script files with the page

@mfshao mfshao marked this pull request as ready for review January 19, 2023 03:14
@cmlsn cmlsn self-requested a review January 19, 2023 22:15
This was referenced Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants