Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PXP-8286): fix(google): add redirect validation to /link/google #927

Merged
merged 5 commits into from
Jun 15, 2021

Conversation

Avantol13
Copy link
Contributor

New Features

Breaking Changes

  • /link/google will DENY requests with "redirect" param values that aren't in the "allowed redirects" for OAuth2/OIDC Clients in Fence

Bug Fixes

Improvements

Dependency updates

Deployment changes

  • /link/google will DENY requests with "redirect" param values that aren't in the "allowed redirects" for OAuth2/OIDC Clients in Fence (You have to add any valid redirects to the client before deploying this)

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Jun 4, 2021

Pull Request Test Coverage Report for Build 11215

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 71.13%

Totals Coverage Status
Change from base Build 11213: 0.007%
Covered Lines: 6135
Relevant Lines: 8625

💛 - Coveralls

@Avantol13 Avantol13 merged commit ddd7ecd into master Jun 15, 2021
@Avantol13 Avantol13 deleted the fix/redirect branch June 15, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants