Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ras url #824

Merged
merged 6 commits into from
Aug 25, 2020
Merged

Fix/ras url #824

merged 6 commits into from
Aug 25, 2020

Conversation

BinamB
Copy link
Contributor

@BinamB BinamB commented Aug 24, 2020 •
edited by paulineribeyre
Loading

Improvements

  • Parameterize discovery url for RAS.

Deployment changes

  • Commons configured with RAS staging login must add the "discovery_url" fence config, because it now defaults to RAS prod

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Aug 24, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 9660

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 69.162%
Totals Coverage Status
Change from base Build 9655: -0.004%
Covered Lines: 5349
Relevant Lines: 7734
💛 - Coveralls

itsJiaqi
itsJiaqi approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@itsJiaqi itsJiaqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Checked in with @fantix who also agrees, default to prod is the way to go.

@BinamB BinamB merged commit 16a0648 into master Aug 25, 2020
@paulineribeyre paulineribeyre deleted the fix/ras_url branch August 26, 2020 15:06
This was referenced Nov 9, 2020
Merged
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Nov 20, 2020
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Jan 25, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Feb 22, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Mar 11, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Oct 21, 2022
Closed
This was referenced Dec 18, 2023
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsJiaqi itsJiaqi itsJiaqi approved these changes

Assignees
No one assigned
Labels
test-apis-rasIntegrationTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BinamB @coveralls @itsJiaqi @themarcelor