Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(monitoring): Adopt new pybase img version. #817

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

themarcelor
Copy link
Contributor

@themarcelor themarcelor commented Aug 12, 2020

Update fence's base image to enable an Nginx Status endpoint.
This is small / harmless change required to unblock a cloud-automation PR: uc-cdis/cloud-automation#1348

New Features

  • New base image pybase3-1.3.0

Breaking Changes

  • This Nginx status endpoint is a hard dependency for the nginx-prometheus-exporter side car. Any older fence image that is used with the Kubernetes deployment descriptor that is declared with the sidecar below will fail to come up.
      - name: nginx-prometheus-exporter
        image: registry.hub.docker.com/nginx/nginx-prometheus-exporter:0.8.0
        args: ["-nginx.scrape-uri", "http://127.0.0.1/nginx_status"]
        ports:
        - containerPort: 9113

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Aug 12, 2020

Pull Request Test Coverage Report for Build 9577

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.209%

Totals Coverage Status
Change from base Build 9558: 0.0%
Covered Lines: 5345
Relevant Lines: 7723

💛 - Coveralls

@themarcelor themarcelor changed the title chore(monitoring): Adopt new pybase img version chore(monitoring): Adopt new pybase img version. Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants