Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXP-2802 feat(usync-emails) #788

Merged
merged 1 commit into from
Jun 23, 2020
Merged

PXP-2802 feat(usync-emails) #788

merged 1 commit into from
Jun 23, 2020

Conversation

vpsx
Copy link
Contributor

@vpsx vpsx commented Jun 16, 2020

Q: Mightn't we as well validate actual provided emails including deliverability checks??
A: Not in usersync; if at all, then in useryaml validation

New Features

  • In usersync, populate user email iff email is provided in useryaml OR username is an email addr

Breaking Changes

  • Usersync will no longer populate user's email field in Fence db with the user's username, UNLESS the username is an email address, in which case previous behavior applies (email field is populated with the username). In other words, nothing should change except in cases where usersync was putting invalid emails into user email fields anyway.

Dependency updates

  • Added dependency email_validator v1.1.1

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9089

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 69.829%

Totals Coverage Status
Change from base Build 9074: 0.03%
Covered Lines: 5212
Relevant Lines: 7464

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants