-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/make region required for s3 bucket config #749
Fix/make region required for s3 bucket config #749
Conversation
…ise an exception when the s3_bucket has no region specified and add comments
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
…://github.com/uc-cdis/fence into fix/make-region-required-for-S3_Bucket-config
Pull Request Test Coverage Report for Build 8413
💛 - Coveralls |
This pull request introduces 1 alert when merging 5bb0862 into 8fefae0 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job! please remove your previous changes of raising a ValueError
when the region
is not specified
…ets for creds and regions. It runs at the end of app_config
…://github.com/uc-cdis/fence into fix/make-region-required-for-S3_Bucket-config
This pull request introduces 2 alerts when merging 0639998 into 8fefae0 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 4aecd15 into 8fefae0 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 84dbfa1 into 8fefae0 - view on LGTM.com new alerts:
|
Improvements
Deployment changes