Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synapse Integration #696

Merged
merged 16 commits into from
Sep 30, 2019
Merged

Synapse Integration #696

merged 16 commits into from
Sep 30, 2019

Conversation

fantix
Copy link
Contributor

@fantix fantix commented Sep 12, 2019 •
edited by paulineribeyre
Loading

New Features

  • Support Synapse as new AuthN and AuthZ provider
  • Support AuthZ Provider feature in Arborist

Dependency updates

  • Requires Arborist 2.3.0

Deployment changes

  • Requires manual work in Arborist DB to fill in the empty authz_provider fields

@github-actions
Copy link

github-actions bot commented Sep 12, 2019 •
edited
Loading

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Sep 12, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 7763

  • 41 of 97 (42.27%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 69.537%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/init.py 3 4 75.0%
fence/blueprints/login/init.py 2 5 40.0%
fence/blueprints/login/base.py 1 5 20.0%
fence/blueprints/login/synapse.py 11 24 45.83%
fence/resources/openid/synapse_oauth2.py 15 50 30.0%
Files with Coverage Reduction New Missed Lines %
fence/sync/sync_users.py 2 75.6%
Totals Coverage Status
Change from base Build 7745: -0.4%
Covered Lines: 4990
Relevant Lines: 7176
💛 - Coveralls

vpsx
vpsx approved these changes Sep 25, 2019
View reviewed changes
@fantix fantix changed the title [WIP] Synapse Integration Synapse Integration Sep 25, 2019
@fantix fantix force-pushed the feat/synapse branch 2 times, most recently from b791f65 to ce565c3 Compare September 30, 2019 13:54
@fantix fantix merged commit 596e153 into master Sep 30, 2019
@fantix fantix deleted the feat/synapse branch September 30, 2019 15:04
This was referenced Feb 10, 2020
Merged
Merged
This was referenced Feb 18, 2020
Closed
Merged
This was referenced Mar 17, 2020
Merged
Closed
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Apr 16, 2020
Closed
This was referenced May 11, 2020
Closed
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpsx vpsx vpsx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fantix @coveralls @vpsx