Feat/requester pays #668
Merged
Feat/requester pays #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…documentation about requester pays support
…project is configured or provided by user
…billing project for signed urls and temp creds
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 7399
💛 - Coveralls |
…illing account is set
paulineribeyre
requested changes
Jul 30, 2019
Co-Authored-By: Pauline Ribeyre <ribeyre@uchicago.edu>
Co-Authored-By: Pauline Ribeyre <ribeyre@uchicago.edu>
Co-Authored-By: Pauline Ribeyre <ribeyre@uchicago.edu>
Co-Authored-By: Pauline Ribeyre <ribeyre@uchicago.edu>
Co-Authored-By: Pauline Ribeyre <ribeyre@uchicago.edu>
paulineribeyre
approved these changes
Jul 31, 2019
| @@ -233,7 +206,7 @@ def give_service_account_billing_access_if_necessary( | |||
| is_default_billing = True | |||
|
|
|||
| if r_pays_project: | |||
| sa_account_id = get_sa_email_from_private_key(sa_private_key) | |||
| sa_account_id = sa_private_key.get("client_email") | |||
There was a problem hiding this comment.
you could pull this out of the if instead of doing it once in each if
This was referenced Feb 10, 2020
This was referenced Mar 17, 2020
This was referenced May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
userProjectfield to Google signed urls if a billing project is provided (by user or by default configuration)Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes