Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated copy feat/s3 delete files #1171

Merged
merged 22 commits into from
Aug 7, 2024
Merged

Conversation

haraprasadj
Copy link
Contributor

@haraprasadj haraprasadj commented Aug 7, 2024

Link to JIRA ticket if there is one: N/A

New Features

  • Adds support for deleting files from non-AWS S3-compatible endpoints (e.g. MinIO, Wasabi, Ceph).

Bug Fixes

  • Fixes the "The AWS Access Key Id you provided does not exist" error when attempting to delete a file from a non-AWS bucket.

Improvements

  • Allows for Gen3 administrators to have greater flexibility in choosing their preferred data storage, while keeping the AWS S3 endpoint as the "default" storage option.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10288705926

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 61 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.1%) to 75.278%

Files with Coverage Reduction New Missed Lines %
resources/ga4gh/passports.py 2 87.43%
blueprints/data/blueprint.py 3 86.9%
init.py 5 90.84%
blueprints/data/multipart_upload.py 9 22.81%
resources/aws/boto_manager.py 42 41.43%
Totals Coverage Status
Change from base Build 10287482728: 0.1%
Covered Lines: 7792
Relevant Lines: 10351

💛 - Coveralls

@BinamB BinamB merged commit 07a2321 into master Aug 7, 2024
15 checks passed
@BinamB BinamB deleted the automatedCopy-feat/s3-delete-files branch August 7, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants