Fix MFA policy management with unknown users #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with usersync and MFA policy management in cases where a user has not been persisted by Fence.
paulineribeyre
approved these changes
Dec 5, 2023
| @@ -1886,7 +1890,7 @@ def _revoke_all_policies_preserve_mfa(self, user): | |||
|
|
|||
| policies = [] | |||
| try: | |||
| policies = self.arborist_client.get_user()["policies"] | |||
There was a problem hiding this comment.
not sure how this ever worked... get_user is missing the required username parameter
Comment on lines
+1045
to
+1048
| syncer._revoke_all_policies_preserve_mfa(user_that_doesnt_exist, "mock_idp") | ||
|
|
||
| # we only care that this doesn't error | ||
| assert True |
There was a problem hiding this comment.
Suggested change
| syncer._revoke_all_policies_preserve_mfa(user_that_doesnt_exist, "mock_idp") | |
| # we only care that this doesn't error | |
| assert True | |
| # we only care that this doesn't error | |
| syncer._revoke_all_policies_preserve_mfa(user_that_doesnt_exist, "mock_idp") |
|
I tested this in the broken environment and it fixed the issue. I reran jenkins. @Avantol13 @k-burt-uch are you ok with merging? |
So long as we make sure the single failing data upload test eventually passes. It makes me a bit nervous force merging but I know this has some production impact |
|
Yes we can wait for jenkins, there seems to be a CI bottleneck but it will probably run by tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes