Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: data upload auth check #702

Merged
merged 1 commit into from
Jul 7, 2020
Merged

fix: data upload auth check #702

merged 1 commit into from
Jul 7, 2020

Conversation

mfshao
Copy link
Collaborator

@mfshao mfshao commented Jul 6, 2020 •
edited
Loading

Fixed a bug cause submission page not correctly displaying Map My Files component if 1. useArboristUI is on AND 2. service in file_upload has been changed from fence to * (which is intruduced in Indexd 2.12.0 or 2020.07)

Related PR: uc-cdis/indexd#275 (see Deployment changes)

Bug Fixes

  • Fixed a bug cause submission page not correctly displaying Map My Files component

Deployment changes

  • Portal should be updated to include this fix if Indexd is above 2.12.0 or 2020.07 and user want to use Arborist UI

@mfshao mfshao requested review from paulineribeyre and vpsx July 6, 2020 22:49
paulineribeyre
paulineribeyre approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

vpsx
vpsx approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@vpsx vpsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thanks!

@vpsx
Copy link
Contributor

vpsx commented Jul 6, 2020

One small pedantic thing but I think the PR description should say service in the file_upload permission in the useryaml. (data_file is the resource)

@mfshao mfshao merged commit 5a9b087 into master Jul 7, 2020
@mfshao mfshao deleted the fix/data-upload-auth-check branch July 7, 2020 03:16
This was referenced Jul 27, 2020
Merged
Closed
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 11, 2020
Merged
Closed
Merged
This was referenced Aug 24, 2020
Merged
Merged
This was referenced Aug 26, 2020
Merged
Merged
Merged
This was referenced Sep 11, 2020
Merged
Merged
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Nov 6, 2020
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Jan 25, 2021
Merged
This was referenced Sep 3, 2021
Merged
Merged
This was referenced Sep 13, 2021
Merged
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Sep 28, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Dec 10, 2021
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jan 11, 2022
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jan 20, 2022
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Feb 3, 2022
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Mar 2, 2022
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Mar 18, 2022
Merged
This was referenced Apr 1, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Oct 21, 2022
Closed
This was referenced Dec 19, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

@vpsx vpsx vpsx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfshao @vpsx @paulineribeyre