Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quiz configurable #571

Merged
merged 7 commits into from
Sep 23, 2019
Merged

Make quiz configurable #571

merged 7 commits into from
Sep 23, 2019

Conversation

abgeorge7
Copy link
Contributor

Description about what this pull request does.

The required popup for a user was restricted to a "Quiz" with correct answers, this allows it to also account for cases that just require an agreement.

New Features

  • Implemented XXX

Breaking Changes

Bug Fixes

Improvements

  • Popup required is now more intuitive for other use cases

Dependency updates

Deployment changes

  • For a "cert" if the required document is a quiz, then hasCorrectAnswers should be true, otherwise false.

Copy link
Collaborator

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic looks good to me. You might need to patch up the Quiz.test.jsx so travis can pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants