Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/dat #563

Merged
merged 5 commits into from
Aug 12, 2019
Merged

Fix/dat #563

merged 5 commits into from
Aug 12, 2019

Conversation

paulineribeyre
Copy link
Contributor

@paulineribeyre paulineribeyre commented Aug 9, 2019 •
edited
Loading

Fix the logic for calculating availability (use case described at uc-cdis/guppy#49)

Also slight change to the heatmap default colors so that it's easier to see the difference between the values

Bug Fixes

  • fix the logic for calculating the availability values in the Data availability tool

Improvements

  • fix the logic for sorting the Data availability tool's Y axis variables by alphabetical order

Deployment changes

  • fixed DAT requires Guppy >= 0.3.1

paulineribeyre
paulineribeyre commented Aug 9, 2019
View reviewed changes
@paulineribeyre paulineribeyre requested a review from mfshao August 9, 2019 22:09
paulineribeyre and others added 2 commits August 12, 2019 11:04
@paulineribeyre @mfshao
guppy to 0.3.1
d426a8e 
Co-Authored-By: Mingfei Shao <2475897+mfshao@users.noreply.github.com>
@paulineribeyre
update package-lock.json
a364e8a
mfshao
mfshao approved these changes Aug 12, 2019
View reviewed changes
Copy link
Collaborator

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this~

@paulineribeyre paulineribeyre merged commit 4fba63c into master Aug 12, 2019
@paulineribeyre paulineribeyre deleted the fix/dat branch August 12, 2019 16:50
@PlanXCyborg PlanXCyborg mentioned this pull request Dec 10, 2021
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jan 11, 2022
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Feb 3, 2022
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Mar 2, 2022
Merged
This was referenced Apr 1, 2022
Closed
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfshao mfshao mfshao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulineribeyre @mfshao