PXD-1312 feat(search): Enable search function for data dictionary view #434

qingyashu · 2018-12-06T22:49:25Z

Deployed in https://qingya.planx-pla.net/DD, try it

New Features

Search function for data dictionary

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

qingyashu · 2018-12-18T16:36:43Z

Dictionary search function deployed in https://qingya.planx-pla.net/DD, please have a try and let me know which part (interactions or UI) you think could improve... thanks! 🙏

ZakirG · 2018-12-18T16:45:49Z

Wow, looks so cool. This page is so much more useful than what was there a month or two ago!!!

Feedbacks:

I think that the highlight on matched nodes could be more dramatic, versus the property matches. For example, when I search "Case", it seems like the matched node just gets a text color change -- can you enlarge the matched node, or highlight its border?
One Web Content Accessibility Guideline is that color alone should not be used to convey meaning. If possible, we should follow this. But I guess that's design feedback :P
The "Expand all Results" button results in some messy UI when there are more than a few nodes with matched properties. Not sure how to fix!
In the search results bullet points, the numbers before "matched Nodes" and "matches in Properties" are blue, which makes them appear clickable, but they aren't -- would "badges" be more appropriate? (like the class .dicionary-search-history__item-count )
The search feature is present on the table view page, but doesn't seem to perform any highlighting functionality there. This feels confusing.

ZakirG · 2018-12-18T16:47:29Z

src/DataDictionary/search/DictionarySearchHistory/DictionarySearchHistory.css

+  border-top: 1px solid var(--g3-color__silver);
+}
+
+.dicionary-search-history__item {


typo! "dicionary" -> "dictionary"

ZakirG · 2018-12-18T16:47:58Z

src/DataDictionary/search/DictionarySearchHistory/DictionarySearchHistory.css

+  background-color: var(--g3-color__gray);
+}
+
+.dicionary-search-history__item:hover .dicionary-search-history__item-count {


more typos! "dicionary" -> "dictionary"

qingyashu · 2018-12-20T16:18:28Z

fix bugs:
- only highlighted one in property types
- a node text highlighting bug (due to Fuse library's bug)
- when selecting a node, and then search, data model structure is not reset
UI changes:
- make the matched result table full-screen table
- when highlighting second node, make first level related node half faded, and with dashed stroke style
- make the matched node name more emphasized, add half opacity for other matched nodes, and with dashed stroke style
small style changes:
- Change highlighted node text to black color
- Add border to legend
- change wording in "xx matches in node properties"
- when start searching, jump to graph view
and many other code refactoring

PlanXCyborg · 2019-01-28T19:34:56Z

Jenkins Build 20 : time taken 24 min

MichaelLukowski

took a while, but everything looks great and works well. LGTM

PlanXCyborg · 2019-01-29T17:53:23Z

Jenkins Build 21 : time taken 1 hr 15 min

abgeorge7

Had some small things

src/DataDictionary/graph/GraphDrawer/GraphDrawer.css

abgeorge7 · 2019-01-29T17:47:32Z

src/DataDictionary/graph/NodePopup/NodePopup.jsx

-    const svgBoundingBox = this.props.highlightingNodeSVGElement
-      && this.props.highlightingNodeSVGElement.getBoundingClientRect
-      ? this.props.highlightingNodeSVGElement.getBoundingClientRect()
+    const highlightingNodeSVGElement = this.props


this.props.graphNodesSVGElements defaults to null, will this line cause problems if it's null and it tries to access a field?

abgeorge7 · 2019-01-29T17:51:47Z

src/DataDictionary/graph/OverlayPropertyTable/OverlayPropertyTable.jsx

+  };
+
+  handleSeeOnlyMatchedProperties = () => {
+    this.props.onCloseMatchedNode();


this names are still kind of confusing to me, if this function is called handleSeeOnlyMatchedProperties I don't expect it to call another function onCloseMatchedNode, which sounds like it closes a panel that displays matches?

abgeorge7 · 2019-01-29T18:15:26Z

src/DataDictionary/search/DictionarySearcher/DictionarySearcher.jsx

+    const { result, errorMsg } = searchKeyword(this.searchData, str);
+    if (!result || result.length === 0) {
+      this.props.setIsSearching(false);
+      this.props.onSearchResultUpdated([], []);


why pass two empty arrays in here?

Because search result is empty here.

abgeorge7 · 2019-01-29T18:16:13Z

src/DataDictionary/search/DictionarySearcher/DictionarySearcher.jsx

+      this.setState({
+        isSearchFinished: true,
+        hasError: true,
+        errorMsg,


I don't think errorMsg was defined in the original state

src/DataDictionary/search/DictionarySearcher/searchHelper.test.js

qingyashu · 2019-01-29T19:21:33Z

Thanks for comments!~ code updated and please have a check again

PlanXCyborg · 2019-01-29T19:39:56Z

Jenkins Build 22 : time taken 24 min

PlanXCyborg · 2019-01-29T20:03:03Z

Jenkins Build 23 : time taken 42 min

PlanXCyborg · 2019-01-29T21:00:20Z

Jenkins Build 24 : time taken 36 min

PlanXCyborg · 2019-01-30T01:21:56Z

Jenkins Build 25 : time taken 1 hr 0 min

PlanXCyborg · 2019-01-30T02:01:41Z

Jenkins Build 26 : time taken 35 min

PlanXCyborg · 2019-01-30T03:00:25Z

Jenkins Build 27 : time taken 31 min

abgeorge7

🎉

feat(search): import search library, and link to autocomplete

1331ef2

qingyashu added the WIP Work in progress label Dec 6, 2018

qingyashu and others added 6 commits December 7, 2018 14:13

feat(node): highlight matched nodes

22a6e7a

feat(history): show search result and add to history

88b7a1f

feat(popup): add popup search result

ced16c1

Merge branch 'master' into feat/dd-search

54f1423

fix(search): add more for search overlay result, and some tests

72e81dd

fix(lint): eslint

d4f9fea

qingyashu removed the WIP Work in progress label Dec 18, 2018

qingyashu requested a review from abgeorge7 December 18, 2018 15:52

fix(search): if start typing, clear all current highlighted nodes

23daa9f

qingyashu requested review from ZakirG and mfshao December 18, 2018 16:11

ZakirG reviewed Dec 18, 2018

View reviewed changes

qingyashu added 4 commits December 18, 2018 14:05

fix(fuse): bug in fuse sometimes return wrong indices, filter out them

a48134e

fix(typo): fix typo

0b8f736

fix(style): some style improvement

8cd54b5

fix(types): fix a bug that only showed one highlighted type

cd39f09

qingyashu added the WIP Work in progress label Dec 19, 2018

qingyashu added 4 commits December 19, 2018 21:40

fix(improve): improve according to review and design check

cd50e63

fix(half-fade): make node and edge half faded effect

8bc3d88

fix(emphasize-node): add half-faded effect for search result

a89827d

fix(test): fix test

5e4daab

qingyashu removed the WIP Work in progress label Dec 20, 2018

qingyashu changed the title ~~WIP feat(search): import search library, and link to autocomplete~~ PXD-1312 feat(search): Enable search function for data dictionary view Dec 20, 2018

qingyashu and others added 2 commits December 20, 2018 12:56

fix(improve): more improve on UI

8d383c8

Merge branch 'master' into feat/dd-search

c05ca62

MichaelLukowski approved these changes Jan 29, 2019

View reviewed changes

fix(version): ui-component version to .22

e1104b5

abgeorge7 reviewed Jan 29, 2019

View reviewed changes

qingyashu added 2 commits January 29, 2019 13:14

fix(review): fix some test and others according to review comments

c2a910d

fix(typo): typo typo

02ab6df

Merge branch 'master' into feat/dd-search

e37d375

fix(NaN): fix console error about NaN

9916178

abgeorge7 approved these changes Jan 30, 2019

View reviewed changes

qingyashu merged commit 4971c9d into master Jan 30, 2019

zflamig deleted the feat/dd-search branch March 17, 2019 15:28

cstephanos mentioned this pull request Nov 4, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#83

Open

urvi-occ mentioned this pull request Nov 4, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#84

Open

pmartinov mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#85

Open

cstephanos mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#86

Open

urvi-occ mentioned this pull request Dec 25, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#97

Open

This was referenced Dec 25, 2022

[Snyk] Fix for 1 vulnerabilities #1192

Closed

[Snyk] Fix for 1 vulnerabilities #1193

Closed

cstephanos mentioned this pull request Dec 25, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#98

Open

snyk-bot mentioned this pull request Dec 25, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#99

Open

cstephanos mentioned this pull request Dec 26, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#100

Open

Mikisha10 mentioned this pull request Dec 26, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#101

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PXD-1312 feat(search): Enable search function for data dictionary view #434

PXD-1312 feat(search): Enable search function for data dictionary view #434

qingyashu commented Dec 6, 2018 •

edited

Loading

qingyashu commented Dec 18, 2018

ZakirG commented Dec 18, 2018 •

edited

Loading

ZakirG Dec 18, 2018

ZakirG Dec 18, 2018

qingyashu commented Dec 20, 2018

PlanXCyborg commented Jan 28, 2019

MichaelLukowski left a comment

PlanXCyborg commented Jan 29, 2019

abgeorge7 left a comment

abgeorge7 Jan 29, 2019

abgeorge7 Jan 29, 2019

abgeorge7 Jan 29, 2019

qingyashu Jan 29, 2019

abgeorge7 Jan 29, 2019

qingyashu commented Jan 29, 2019

PlanXCyborg commented Jan 29, 2019

PlanXCyborg commented Jan 29, 2019

PlanXCyborg commented Jan 29, 2019

PlanXCyborg commented Jan 30, 2019

PlanXCyborg commented Jan 30, 2019

PlanXCyborg commented Jan 30, 2019

abgeorge7 left a comment

PXD-1312 feat(search): Enable search function for data dictionary view #434

PXD-1312 feat(search): Enable search function for data dictionary view #434

Conversation

qingyashu commented Dec 6, 2018 • edited Loading

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

qingyashu commented Dec 18, 2018

ZakirG commented Dec 18, 2018 • edited Loading

ZakirG Dec 18, 2018

Choose a reason for hiding this comment

ZakirG Dec 18, 2018

Choose a reason for hiding this comment

qingyashu commented Dec 20, 2018

PlanXCyborg commented Jan 28, 2019

MichaelLukowski left a comment

Choose a reason for hiding this comment

PlanXCyborg commented Jan 29, 2019

abgeorge7 left a comment

Choose a reason for hiding this comment

abgeorge7 Jan 29, 2019

Choose a reason for hiding this comment

abgeorge7 Jan 29, 2019

Choose a reason for hiding this comment

abgeorge7 Jan 29, 2019

Choose a reason for hiding this comment

qingyashu Jan 29, 2019

Choose a reason for hiding this comment

abgeorge7 Jan 29, 2019

Choose a reason for hiding this comment

qingyashu commented Jan 29, 2019

PlanXCyborg commented Jan 29, 2019

PlanXCyborg commented Jan 29, 2019

PlanXCyborg commented Jan 29, 2019

PlanXCyborg commented Jan 30, 2019

PlanXCyborg commented Jan 30, 2019

PlanXCyborg commented Jan 30, 2019

abgeorge7 left a comment

Choose a reason for hiding this comment

qingyashu commented Dec 6, 2018 •

edited

Loading

ZakirG commented Dec 18, 2018 •

edited

Loading