Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PXP-7565): Exclude Fence register-user blueprint from CSRF check #1580

Merged
merged 1 commit into from
Apr 26, 2021
Merged

(PXP-7565): Exclude Fence register-user blueprint from CSRF check #1580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions kube/services/revproxy/gen3.nginx.conf/fence-service.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ location /user/ {
proxy_pass $upstream;
}

location /user/register-user {
# Like /user/ but without CSRF check. Registration form submission is
# incompatible with revproxy-level cookie-to-header CSRF check.
# Fence enforces its own CSRF protection here so this is OK.
set $proxy_service "${fence_release_name}";
set $upstream http://${fence_release_name}-service$des_domain;
rewrite ^/user/(.*) /$1 break;
proxy_pass $upstream;
}

location /user/data/download {
if ($csrf_check !~ ^ok-\S.+$) {
return 403 "failed csrf check";
Expand Down