deploy stata ws #7407
Merged
deploy stata ws #7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfshao
commented
May 14, 2024
| @@ -9,6 +9,8 @@ | |||
| "account_id": "252835817747", | |||
| "workspace_type": "healworkspaces" | |||
| }, | |||
| "license-user-maps-dynamodb-table": "gen3-license-user-maps-prod-heal", | |||
There was a problem hiding this comment.
@george42-ctds can youy remind me if we need PE's help to create this table before we deploy, or hatchery will created automatically if it doesn't exists?
There was a problem hiding this comment.
Right, the kube-setup-hatchery.sh will check for a license-user-maps-dynamodb-table in the hatchery.json. It will create the table if the table does not already exist. I think the plan was to use different table names for preprod and prod, to get two different tables.
So, the table should be created automatically without help from PE.
There was a problem hiding this comment.
great! thanks for the confirmation, want also help to review this PR? 😉
healdata.org/manifest.jsonDeployment changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira ticket if there is one:
Environments
Description of changes