-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies #2500
update dependencies #2500
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2500 +/- ##
=======================================
Coverage 74.14% 74.14%
=======================================
Files 28 28
Lines 932 932
=======================================
Hits 691 691
Misses 241 241
Continue to review full report at Codecov.
|
Using a schema causes avj to validate the schema passed into the store, but as we use non-standardized key names, it will fail the strict check. Pass in options instead of a schema, as these do not get strictly validated. This is in preparation to update to a new version of electron-store which updates avj and triggers this issue: ----- A JavaScript error occurred in the main process Uncaught Exception: Error: strict mode: unknown keyword: "opencuts" at checkStrictMode (/android/halium/projects/ubports-installer/node_modules/conf/node_modules/ajv/dist/compile/util.js:174:15) at checkUnknownRules (/android/halium/projects/ubports-installer/node_modules/conf/node_modules/ajv/dist/compile/util.js:32:13) at alwaysValidSchema (/android/halium/projects/ubports-installer/node_modules/conf/node_modules/ajv/dist/compile/util.js:19:5) at /android/halium/projects/ubports-installer/node_modules/conf/node_modules/ajv/dist/vocabularies/applicator/properties.js:23:81 at Array.filter (<anonymous>) at Object.code (/android/halium/projects/ubports-installer/node_modules/conf/node_modules/ajv/dist/vocabularies/applicator/properties.js:23:37) at keywordCode (/android/halium/projects/ubports-installer/node_modules/conf/node_modules/ajv/dist/compile/validate/index.js:454:13) at /android/halium/projects/ubports-installer/node_modules/conf/node_modules/ajv/dist/compile/validate/index.js:222:17 at CodeGen.code (/android/halium/projects/ubports-installer/node_modules/conf/node_modules/ajv/dist/compile/codegen/index.js:439:13) at CodeGen.block (/android/halium/projects/ubports-installer/node_modules/conf/node_modules/ajv/dist/compile/codegen/index.js:568:18) ----- Change-Id: Ib7ae997611697cc0c91d4da84e117f78e0f2a1c5 Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Change-Id: I80f2ccdd17c218963f10602b8ea25cda8ca8baec Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Change-Id: I683def0cdccd3955808b72d432778ebc0798b6d1 Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Change-Id: I88bbb34ab53cced11648aadc5bf0eec528552796 Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Change-Id: Ib33308c08a910618d2828db401658169ad9ceec3 Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
Change-Id: Ifac87af3ec15d7f0def678c9ee912b68afde31db Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
daf7bc1
to
a238696
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Update dependencies:
npm update --save
axios
manually to0.26.1
electron
manually up to17.1.2
electron-store
manually to8.0.1