feat: added it87-extras for improved lm-sensors compatibility with some Gigabyte motherboards

[grandpares]

Description

This recipe installs it87-extras, a packaged version of frankcrawford/it87 adding support for some Gigabyte motherboards. This package does not replace mainline it87 but installs a blacklist file for it as a dependency (contained in copr/grandapres/it87-extras/it87-extras-common).

Usecase

The primary purpose of the controllers this driver enables is PWM control of case fans, which is important for gaming systems. Therefore, this will be useful in Bazzite.

Issues

For most systems unsupported in the mainline, forcing controller ID when modprobing the driver and acpi_enforce_resources=lax are both necessary. Since the chip ID depends on the motherboard, and acpi_enforce_resources=lax is potentially destructive, neither should be set by default. A justfile that looks at the output of setup-sensors and then sets the necessary kargs is a possible solution, although I'm not sure where I could contribute one. However, users on unsupported systems should not experience any degradations compared to the mainline driver if these kargs are not set (their PWM controllers won't work in both cases).

Testing

I have tested that this module builds and installs from copr to akmod in Fedora 40 (mutable). Additionally, it builds from source, loads, and works as expected in aurora:stable. I wasn't sure if the akmods repo build actions are safe to run for testing, but if so, I can verify the image builds before merging. Currently, the copr repo is set to build from my fork of the module while I'm waiting for the upstream to review a PR containing the copr spec files.

[grandpares]

Looks like the build workflows must be triggered before review anyway, updated pr to ready to review to allow maintainer to trigger
Thank you for maintaining this project. Please reach out with any additional questions via this pull request.

[bsherman]

@KyleGospo @HikariKnight @antheas

Have you discussed the inclusion of this kmod. If we were to merge would it get installed in Bazzite?

I think that's the critera for "extra" kmod additions at this point: "Does Bazzite plan to ship it?"

[KyleGospo]

I'd consider it, first time seeing this.

[bsherman]

@grandpares as is this doesn't actually build, your new build script needs to be added to the Containerfile.extra .

That will at least get it building for validation while the Bazzite team takes a look.

[grandpares]

Done, can you re-run build checks to make sure everything works @bsherman ?

[grandpares]

Okay, I think I know what's going on with the build failures. Purged some old builds that were messing with version control and renamed variables in the spec, seems to pick up the kernel version that akmods passes now. Hopefully this will fix it.

[grandpares]

@bsherman could you rerun the build checks to make sure everything builds now?

[grandpares]

@castrojo @bsherman I've finally found some time to test-build the entire akmods image with this included and resolve buildtime issues. Everything should build now. Thus marking this ready for review again.
As of right now, I'm not loading this module automatically when installed because it can require extra setup on the user's part depending on their mb. That being said, if you want this to change and the module to be modprobed on boot, this can be done via a copr update, will not require changes to this repo, and should work for most cases.
Additionally, including this apparently resolves #191.

[Toetje585]

This would also allow me to get better fan control on my custom build BD790I running Bazzite-Deck. Would be cool to see this happening.

[Stefkeys]

Is this still being reviewed for merging into main branch?

[ledif]

There is a merge conflict in test-prep.sh which needs to be resolved before the CI can run. @grandpares are you able to resolve that conflict?

[grandpares]

@ledif Looks like the upstream architecture has changed somewhat since the last sync, I'll try to reconcile and push a commit this weekend

[ledif]

Build seems to be passing. LGTM.

[bsherman]

@ublue-os/approver

I'm indifferent to the addition of this on technical grounds, the script, code, etc, seems to match everything we are doing elsewhere. I don't have strong opinion on the kernel module itself.

My concerns are about supply chain and long term maintenance.

1. I only think this should be merged if Bazzite or another ublue org downstream projects intends to ship it. That's a bit hard to tell from the context of the PR. It doesn't close an issue. It wasn't requested in Github from any of our projects, so if it was requested in Discord, ok, but we don't have a way to see that in Github.
2. We have been pushing back on adding any new 3rd party COPR repos and the upstream for this is a personal COPR. So, if agreed we want this, this is a known exception to our process.

NOTE: We do still have some 3rd COPRs/git repos in here... eg HikariKnight (but a ublue-approver)... mulderje, where I think I raised same concern and got overruled. :-) ssweeny, I think I was told that's an official System76 account...

So... leaving this here. I'm not going to fully block inclusion, but I won't approve for these reasons.