Please drop unmaintained golang.org/x/lint dependency from go.mod #92
Comments
|
Or even better, use golangci-lint. See #95. |
sywhang
pushed a commit
that referenced
this issue
Feb 6, 2023
Fixes #92. Avoid tools dependencies in goleak's go.mod. golint is deprecated, we can separately migrate to another tool, but the tools change avoids any CI-time dependency from leaking into our go.mod.
moisesvega
added a commit
that referenced
this issue
Feb 6, 2023
Follow-up to #92. Revive is a drop-in replacement for golint that's faster. Setting up a basic configuration that we can be tweaked going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The golang.org/x/lint library is marked as deprecated / unmaintained / readonly
This library takes an explicit dependency on it in https://github.com/uber-go/goleak/blob/master/tools_test.go in order to record a specific version of it in go.mod, for use with
go installin themake linttarget.The same result could be achieved by installing the same version explicitly in
make lintwithgo install golang.org/x/lint/golint@v0.0.0-20190930215403-16217165b5de, and the tools_test.go and go.mod reference could be dropped, to avoid propagating an unmaintained dependency into downstreams that use this library.The text was updated successfully, but these errors were encountered: