Add advancedOption API with arguments support #84
Conversation
| def other(option: String, args: List[String], isSupported: ScalaVersion => Boolean): ScalacOption = | ||
| def other( | ||
| option: String, | ||
| args: List[String], |
There was a problem hiding this comment.
Also noticing here that the naming is not in line with previously existing privateOption
There was a problem hiding this comment.
Hmm do you mean the argument names? This is because def other was added after the ScalacOption breaking changes in 0.4.0.
There was a problem hiding this comment.
yes, the argument name is not the same. It was named arguments in privateOption.
This isn't a problem at all. Just raising an inconsistency :)
There was a problem hiding this comment.
Yes it's a good point, I wonder if we could use https://www.scala-lang.org/api/2.13.5/scala/deprecatedName.html to bring them all in line
RustedBones
changed the title
| def other(option: String, args: List[String], isSupported: ScalaVersion => Boolean): ScalacOption = | ||
| def other( | ||
| option: String, | ||
| args: List[String], |
There was a problem hiding this comment.
Hmm do you mean the argument names? This is because def other was added after the ScalacOption breaking changes in 0.4.0.
RustedBones
force-pushed
the
advanced-args
branch
from
d1ebe10 to
0ba3695
Compare
As a user, I would like to define the following option in a consistent way:
-Xmax-classfile-name 100with