Migrate to scalac-options library #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidGregory084
force-pushed
the
migrate-to-scalac-options
branch
from
06de067 to
0b94465
Compare
|
I think this is good to go, but I'd like to get a fix for #102 out on 0.4.x before merging |
I think it happened. Is this unblocked now? |
|
@DavidGregory084 what's the status on this? seems fine to be merged |
|
Hey @laughedelic, @mihaisoloi you're right - this should have been merged. I will try to resynchronise scalac-options and sbt-tpolecat next week so that we can merge this. |
DavidGregory084
force-pushed
the
migrate-to-scalac-options
branch
from
0b94465 to
31807e9
Compare
DavidGregory084
commented
Jul 18, 2023
| @@ -84,6 +84,7 @@ val Scala212Options = | |||
| "-Xlint:by-name-right-associative", | |||
| "-Xlint:constant", | |||
| "-Xlint:delayedinit-select", | |||
| "-Xlint:deprecation", | |||
There was a problem hiding this comment.
Backported to Scala 2.12.13 in scala/scala#9248
DavidGregory084
commented
Jul 18, 2023
| @@ -111,6 +112,7 @@ val Scala212Options = | |||
| "-Ywarn-unused:params", | |||
| "-Ywarn-unused:patvars", | |||
| "-Ywarn-unused:privates", | |||
| "-Ywarn-unused:nowarn", | |||
There was a problem hiding this comment.
Also backported in scala/scala#9248
|
This is good to go. Unfortunately we're just waiting for Maven Central sync on scalac-options 0.1.3! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the plugin to use the typelevel/scalac-options library. Fixes #104.
This is not a binary compatible change.