Merge pull request #85 from typelevel/remove-checkinit

Remove -Xcheckinit from the default option set

CHANGELOG.md

@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Early Semantic Versioning](https://docs.scala-lang.org/overviews/core/binary-compatibility-for-library-authors.html#recommended-versioning-scheme) in addition to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Added
+
+* [#84](https://github.com/typelevel/sbt-tpolecat/pull/84) - An `advancedOption` overload with support for multiple argument options was added.
+
+### Changed
+
+* [#85](https://github.com/typelevel/sbt-tpolecat/pull/85) - `-Xcheckinit` was removed from the default option set. After discussion on issues [#10](https://github.com/typelevel/sbt-tpolecat/issues/10) and [#83](https://github.com/typelevel/sbt-tpolecat/issues/83) it has become apparent that although `-Xcheckinit` offers a lot of value for some users, it creates some very tricky problems for users that are writing async code. The initialization checking code this option produces introduces `@volatile` variables that can disguise memory visibility issues.
+
 ## [0.4.0] - 2022-07-15
 
 NOTE: This release series will be the final one released under the group ID `io.github.davidgregory084`, and the final one using the package `io.github.davidgregory084`.

src/main/scala/io/github/davidgregory084/ScalacOptions.scala

@@ -369,7 +369,6 @@ private[davidgregory084] trait ScalacOptions {
   /** Advanced options (-X)
     */
   val advancedOptions: Set[ScalacOption] = ListSet(
-    checkInit,
     lint
   ) ++ lintOptions
 

src/sbt-test/sbt-tpolecat/scalacOptions/build.sbt

@@ -38,7 +38,6 @@ val Scala211Options =
     "-language:experimental.macros",
     "-language:higherKinds",
     "-language:implicitConversions",
-    "-Xcheckinit",
     "-Xlint:adapted-args",
     "-Xlint:by-name-right-associative",
     "-Xlint:delayedinit-select",
@@ -77,7 +76,6 @@ val Scala212Options =
     "-language:experimental.macros",
     "-language:higherKinds",
     "-language:implicitConversions",
-    "-Xcheckinit",
     "-Xlint:adapted-args",
     "-Xlint:by-name-right-associative",
     "-Xlint:constant",
@@ -122,7 +120,6 @@ val Scala213Options =
     "-language:experimental.macros",
     "-language:higherKinds",
     "-language:implicitConversions",
-    "-Xcheckinit",
     "-Xlint:adapted-args",
     "-Xlint:constant",
     "-Xlint:delayedinit-select",