Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce binary compatibility with MiMa SBT plugin #809

Merged
merged 3 commits into from
Jan 26, 2016

Conversation

DavidGregory084
Copy link
Member

This should not be merged until 0.4.0 is released with cats-kernel as a distinct artifact.

Enables the Migration Manager SBT plugin for the kernel module and ensures binary compatibility issues are reported by validateJVM.

@DavidGregory084
Copy link
Member Author

Specific breaking changes can be allowed as per Migration Manager's docs: Sbt plugin: Advanced Usage (Filtering Binary Incompatibilities)

@dwijnand
Copy link
Contributor

👍 for putting this in place now

In your place I would:

  • set previousArtifacts to an empty set
  • open a ticket about adding cats-kernel 0.4.0 to it post-0.4.0 release
  • leaving a comment next to that empty previousArtifacts explaining it's in place for cats-kernel's first release with the ticket number
  • getting this merged into master today :)

@DavidGregory084
Copy link
Member Author

Will do, thanks @dwijnand :)

@codecov-io
Copy link

Current coverage is 85.56%

Merging #809 into topic/kernel will not affect coverage as of ae9576b

@@            topic/kernel    #809   diff @@
============================================
  Files                175     175       
  Stmts               2557    2557       
  Branches             108     108       
  Methods                0       0       
============================================
  Hit                 2188    2188       
  Partial                0       0       
  Missed               369     369       

Review entire Coverage Diff as of ae9576b

Powered by Codecov. Updated on successful CI builds.

@non
Copy link
Contributor

non commented Jan 18, 2016

👍

@non
Copy link
Contributor

non commented Jan 18, 2016

Thanks!

@dwijnand
Copy link
Contributor

👍

@ceedubs
Copy link
Contributor

ceedubs commented Jan 26, 2016

Fantastic. Thanks @DavidGregory084! I tried this once before and couldn't get it figured out. You have succeeded where I failed :)

ceedubs added a commit that referenced this pull request Jan 26, 2016
Enforce binary compatibility with MiMa SBT plugin
@ceedubs ceedubs merged commit e7affc9 into typelevel:topic/kernel Jan 26, 2016
@dwijnand
Copy link
Contributor

Oh this was pull requested to topic/kernel, not master.

@DavidGregory084
Copy link
Member Author

@dwijnand Yep, and it only checks kernel right now - I think this could be expanded pretty easily after 1.0 though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants