-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scalafix for contramap #1937
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/* | ||
rule = "scala:fix.v1_0_0.ContraMapToLMap" | ||
*/ | ||
package fix | ||
package to1_0_0 | ||
|
||
|
||
|
||
object ContraMapToLMapTests { | ||
import cats.Show | ||
import cats.syntax.all._ | ||
import cats.instances.all._ | ||
|
||
val f: Int => String = _.toString | ||
|
||
val g: Int => String = f.contramap(_ + 1) | ||
|
||
object Foo | ||
object Bar | ||
object Baz | ||
|
||
implicit val showFoo: Show[Foo.type] = Show.fromToString | ||
|
||
val showBar: Show[Bar.type] = showFoo.contramap(_ => Foo) | ||
|
||
val showBaz: Show[Baz.type] = Show[Foo.type].contramap(_ => Foo) | ||
|
||
def getShowBar(): Show[Bar.type] = showBar | ||
|
||
getShowBar().contramap((_: Int) => Bar) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package fix | ||
package to1_0_0 | ||
|
||
|
||
|
||
object ContraMapToLMapTests { | ||
import cats.Show | ||
import cats.syntax.all._ | ||
import cats.instances.all._ | ||
|
||
val f: Int => String = _.toString | ||
|
||
val g: Int => String = f.lmap(_ + 1) | ||
|
||
object Foo | ||
object Bar | ||
object Baz | ||
|
||
implicit val showFoo: Show[Foo.type] = Show.fromToString | ||
|
||
val showBar: Show[Bar.type] = showFoo.contramap(_ => Foo) | ||
|
||
val showBaz: Show[Baz.type] = Show[Foo.type].contramap(_ => Foo) | ||
|
||
def getShowBar(): Show[Bar.type] = showBar | ||
|
||
getShowBar().contramap((_: Int) => Bar) | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ package fix | |
package v1_0_0 | ||
|
||
import scalafix._ | ||
import scalafix.syntax._ | ||
import scalafix.util.SymbolMatcher | ||
import scala.meta._ | ||
import scala.meta.contrib._ | ||
|
@@ -73,6 +74,33 @@ case class RemoveCartesianBuilder(index: SemanticdbIndex) | |
} | ||
} | ||
|
||
// ref: https://github.com/typelevel/cats/issues/1850 | ||
case class ContraMapToLMap(index: SemanticdbIndex) | ||
extends SemanticRule(index, "UseLMapInsteadOfContraMap") { | ||
|
||
//val contraMap = Symbol("_root_.cats.functor.Contravariant.Ops.contramap") | ||
|
||
|
||
override def fix(ctx: RuleCtx): Patch = { | ||
|
||
val contraMatcher = SymbolMatcher.normalized(Symbol("_root_.cats.functor.Contravariant.Ops.`contramap`.")) | ||
|
||
val unApplyName = "catsUnapply2left" | ||
|
||
ctx.tree.collect { | ||
case Term.Apply(fun, _) => | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SymbolMatches have an
|
||
if (contraMatcher.matches(fun) && | ||
fun.children.headOption.flatMap(index.denotation).exists{ x => println(x.name == unApplyName); x.name == unApplyName }) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This denotation trick is nice |
||
fun.children.find(contraMatcher.matches).map(tree => ctx.replaceTree(tree, "lmap")).getOrElse(Patch.empty) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} else { | ||
Patch.empty | ||
} | ||
case _ => Patch.empty | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no need for this case, since this is a |
||
|
||
}.asPatch | ||
} | ||
} | ||
|
||
// ref: https://github.com/typelevel/cats/pull/1583 | ||
case class RemoveUnapply(index: SemanticdbIndex) | ||
extends SemanticRule(index, "RemoveUnapply") { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dead code?