Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monoid and Order for Vector #919

Closed
davegurnell opened this issue Mar 7, 2016 · 2 comments
Closed

Monoid and Order for Vector #919

davegurnell opened this issue Mar 7, 2016 · 2 comments

Comments

@davegurnell
Copy link

Vector doesn't have a Monoid, which would allow it to be used as a log in a Writer. It also doesn't have an Order. The two type classes are brought in from algebra and defined side-by-side for List:

https://github.com/typelevel/cats/blob/master/core/src/main/scala/cats/std/list.scala#L68-L69

This is potentially related to typelevel/algebra#50, which would add the relevant type classes to algebra.

@davegurnell davegurnell changed the title Add Monoid for Vector Monoid and Order for Vector Mar 7, 2016
@ceedubs
Copy link
Contributor

ceedubs commented Jun 18, 2016

@davegurnell sorry for the long delay, but I think this was fixed in #1001 and should be in the most recent release. I'm going to go ahead and close this out. Please feel free to reopen it if I've missed anything.

@ceedubs ceedubs closed this as completed Jun 18, 2016
@davegurnell
Copy link
Author

No worries. Awesome news that it was fixed - thanks for the update!
On Sat, 18 Jun 2016 at 19:03, Cody Allen notifications@github.com wrote:

Closed #919 #919.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#919 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAOI5y4YJTTEO9021QuiiBF_--_aXZFLks5qNDLWgaJpZM4Hqav6
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants