Implemented very silly workaround for #807 #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
commented
Apr 29, 2020
| @@ -169,8 +169,8 @@ sealed abstract class Resource[+F[_], +A] { | |||
| * | |||
| **/ | |||
| def parZip[G[x] >: F[x]: Sync: Parallel, B]( | |||
| that: Resource[G, B] | |||
| ): Resource[G, (A, B)] = { | |||
| that: Resource[G[?], B] | |||
There was a problem hiding this comment.
I'm not sure this one is necessary, btw.
|
Seems like it works 🤷 |
|
Could you explain what it does, I'm slightly at a loss :) |
|
@SystemFw It seems like, when it comes to variant constructors, |
|
Weird. Should we use the new kind projector syntax with `*` ?
…On Wed, Apr 29, 2020, 16:05 Daniel Spiewak ***@***.***> wrote:
@SystemFw <https://github.com/SystemFw> It seems like, when it comes to
variant constructors, F and [x]F[x] are not *entirely* equal inside of
scalac. So what my workaround does is I replaced F with [x]F[x] in the
type signatures. This is invisible 99.9% of the time, but in this case it
appears to entirely fix the inference.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#849 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3I33R2F7BMC3GP3RD5MWDRPA64DANCNFSM4MTMH26Q>
.
|
|
@SystemFw I was going to implement that change across the whole project soon. For now, I just went with what was already there. |
|
Ah! Makes sense
…On Wed, Apr 29, 2020, 18:42 Daniel Spiewak ***@***.***> wrote:
@SystemFw <https://github.com/SystemFw> I was going to implement that
change across the whole project soon. For now, I just went with what was
already there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#849 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3I33SZKWBWKBRS5LFAJRDRPBRJZANCNFSM4MTMH26Q>
.
|
LukaJCB
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would also appreciate a look from @neko-kai. I think this works around the issue. It's a little annoying, but I wasn't able to find anything more elegant, and the nice thing is that it doesn't touch binary compatibility. I believe it should also be fully source-compatible with all existing call-sites that weren't already broken.
Fixes #807 (I think)