Fix ModuleNode instanciation when $embeddedTemplates is null
#4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @alexandre-daubois. |
xabbuh
reviewed
Feb 28, 2025
| @@ -41,7 +41,7 @@ public function __construct(Node $body, ?AbstractExpression $parent, Node $block | |||
| if (!$embeddedTemplates instanceof Node) { | |||
| trigger_deprecation('twig/twig', '3.21', \sprintf('Not passing a "%s" instance as the "embedded_templates" argument of the "%s" constructor is deprecated.', Node::class, static::class)); | |||
|
|
|||
| $embeddedTemplates = new Nodes($embeddedTemplates); | |||
| $embeddedTemplates = new Nodes($embeddedTemplates ?? []); | |||
There was a problem hiding this comment.
What about leveraging EmptyNode if $embeddedTemplates is null (see #4608)?
There was a problem hiding this comment.
Thank you for the PR!
xabbuh
added a commit
to symfony/symfony
that referenced
this pull request
Mar 1, 2025
… (alexandre-daubois) This PR was merged into the 6.4 branch. Discussion ---------- [TwigBridge] Fix `ModuleNode` call in `TwigNodeProvider` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT After twigphp/Twig#4604, related to twigphp/Twig#4607 Commits ------- a304e24 [TwigBridge] Fix `ModuleNode` call in `TwigNodeProvider`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to symfony/symfony#59886, in case
$embeddedTemplatesis null