Toolchain registration macros #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rules exported by this file all pertain to Nixpkgs, not Nix directly.
nmattia
approved these changes
Jan 22, 2019
| @@ -299,3 +308,10 @@ def haskell_toolchain( | |||
| exec_compatible_with = exec_compatible_with, | |||
| target_compatible_with = target_compatible_with, | |||
| ) | |||
|
|
|||
| def haskell_register_toolchains(version): | |||
There was a problem hiding this comment.
Don't forget to update the CHANGELOG, since AFAICT the default changed from nixpkgs to bindist
| def _ghc_nixpkgs_toolchain_impl(repository_ctx): | ||
| # These constraints might look tautological, because they always | ||
| # match the host platform if it is the same as the target | ||
| # platform. But they are important to state because Bazel |
This function registers all known GHC binary distributions as toolchains. Each toolchain has appropriate exec and target constraints defined, so that on any given platform, only one bindist will be selected.
This works the same as `haskell_register_ghc_bindists`, except that we are registering a Nixpkgs package, rather than a bindist. Nixpkgs toolchains are now gated with the `//haskell/platforms:nixpkgs` config value. To turn it on, you need to specify the `linux_x86_64_nixpkgs` or `darwin_x86_64_nixpkgs` platforms.
mboes
force-pushed
the
multi-toolchain-register
branch
from
ec45656 to
19f51e9
Compare
guibou
reviewed
Jan 22, 2019
| @@ -264,6 +226,9 @@ rule_test( | |||
| rule = "//tests/java_classpath", | |||
| ) | |||
|
|
|||
| # Keep in sync with test_ghc_version in WORKSPACE. | |||
There was a problem hiding this comment.
Conflict with #614, be careful.
| ) | ||
|
|
||
| haskell_register_ghc_bindists(version = test_ghc_version) |
There was a problem hiding this comment.
No compiler_flags or haddock_flags for that one?
There was a problem hiding this comment.
These should be added, for symmetry with haskell_register_ghc_nixpkgs. They weren't needed for the MVP though (since we currently only use bindists on windows and on windows we currently don't want to set any special flags - until we can propertly support them).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously hard to let the user select between a Nixpkgs based
toolchain and a binary distributions based one. Most
projects (including rules_haskell) were essentially hardcoding this
choice for the user. It is now much easier to do. The trick is to
supply three new workspace macros:
The second function above defines and registers one toolchain per
binary distribution. So e.g. one for Windows, one for Linux etc. The
third one currently defines exactly one toolchain, which matches the
constraints of the host platform. It might define more in the
future (in particular cross-compilers).
As a project author, you are free to just the second one or just the
third one, or both. While the Nixpkgs toolchain was always selected if
it existed previously, now it will only be selected if the user
explicitly sets the host platform in a certain way. See the
documentation about the details.