Make c2hs a separate toolchain. #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profpatsch
approved these changes
Jan 18, 2019
There was a problem hiding this comment.
Looks good! Was this necessary because c2hs doesn’t work on Windows?
Update: Looks like it. https://github.com/tweag/rules_haskell/pull/581/files#diff-a376c47dc40424f31d9cd7b3543e4850R23
guibou
approved these changes
Jan 18, 2019
| register_toolchains("//:c2hs") | ||
| ``` | ||
|
|
||
| """ |
There was a problem hiding this comment.
A new line between the doc and the implementation?
There was a problem hiding this comment.
This is the default Emacs style for docstrings in Python. Can't say I'm a fan. But we already have this in a few places in the code.
The GHC toolchain could previously optionally be provided an extra "tool", c2hs. But This is a **breaking change**. But few people use c2hs and the change is only in the toolchain declaration code, which happens only once per workspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GHC toolchain could previously optionally be provided an extra
"tool", c2hs. But
This is a breaking change. But few people use c2hs and the change
is only in the toolchain declaration code, which happens only once per
workspace.