Make REPL outputs force their dependencies #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkkrp
force-pushed
the
make-repl-outputs-force-their-dependencies
branch
from
bf51b69 to
1cf8f95
Compare
This fixes the regression introduced by #352: we have removed the dependency on compiled “parent” target, but this also removed dependency on other things that are necessary to run a REPL, such as: * Haskell library dependencies * pre-processed source files (hsc and chs) * external shared libraries And so they won't be built if a REPL is built. This commit restores the dependencies allowing to run REPL without having to build its “parent” target before that (still this does not cancel the intended effects of #352).
mrkkrp
force-pushed
the
make-repl-outputs-force-their-dependencies
branch
from
1cf8f95 to
fb66bb9
Compare
mboes
force-pushed
the
master
branch
3 times, most recently
from
cb2b7ef to
a65d39a
Compare
mboes
approved these changes
Jul 24, 2018
Profpatsch
reviewed
Jul 24, 2018
| hs.tools.ghci, | ||
| ghci_repl_script, | ||
| repl_file, | ||
| ]), |
There was a problem hiding this comment.
You can add the current elements directly to the depset, like so:
depset([e1, e2], transitive = [depset1, depset2])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the regression introduced by #352: we have removed the dependency on compiled “parent” target, but this also removed dependency on other things that are necessary to run a REPL, such as:
And so they won't be built if a REPL is built.
This commit restores the dependencies allowing to run REPL without having to build its “parent” target before that (still this does not cancel the intended effects of #352).