Add deprecation notes for the ‘prebuilt_dependencies’ attribute #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboes
approved these changes
Jul 21, 2018
|
Would be good to adjust tests as well. Or the test suite will be generating a ton of warnings. |
|
Should also file a feature request upstream for attribute-level deprecation warnings. |
mrkkrp
force-pushed
the
deprecate-prebuilt-dependencies
branch
2 times, most recently
from
bfe3b62 to
7546d97
Compare
|
Opened an issue with a feature request: bazelbuild/bazel#5654. |
mrkkrp
force-pushed
the
deprecate-prebuilt-dependencies
branch
from
7546d97 to
e31bd53
Compare
thumphries
pushed a commit
to thumphries/rules_haskell
that referenced
this pull request
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.