Extra source files #292
Merged
Extra source files #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judah
approved these changes
Jun 4, 2018
haskell/haskell.bzl
Outdated
| @@ -46,6 +46,10 @@ _haskell_common_attrs = { | |||
| allow_files = FileType([".hs", ".hsc", ".chs", ".lhs", ".hs-boot", ".lhs-boot", ".h"]), | |||
| doc = "Haskell source files.", | |||
| ), | |||
| "extra_srcs": attr.label_list( | |||
| allow_files = True, | |||
| doc = "Extra (non-Haskell) source files that will be needed at compile time (e.g. by TH).", | |||
There was a problem hiding this comment.
Suggestion: clarify these docs by expanding "TH" to "Template Haskell".
| embedFile :: FilePath -> Q Exp | ||
| embedFile path = do | ||
| str <- runIO (readFile path) | ||
| addDependentFile path |
There was a problem hiding this comment.
A question: I guess addDependentFile is mostly only needed for reloading in the REPL, right? Otherwise I believe Bazel would track the dependency on the input file automatically.
There was a problem hiding this comment.
Well I just added it because it was the right thing to do. It doesn't hurt in either case, does it?
mboes
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #291.
This makes it possible to compile TH code that references external files with arbitrary extensions, see the test. Unfortunately this still doesn't work out-of-the-box with Hackage packages because the path to files should include package names. Not a problem for new code though.