Fix TemplateHaskell linking against cc_library targets on macOS. #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As with the binary, we need to use `install_name_tool` to correct linker paths so they're relative to the file that references them. Modifies a test to add a `cc_library` dependency. Previously all the tests only depended on Nix-supplied C libraries, which have absolute paths and thus weren't triggering this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with the binary, we need to use
install_name_toolto correctlinker paths so they're relative to the file that references them.
Modifies a test to add a
cc_librarydependency. Previously allthe tests only depended on Nix-supplied C libraries, which have
absolute paths and thus weren't triggering this bug.