-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WASM-based Ormolu Live #964
Conversation
@amesgen Thanks for doing this, I’ll take a look later. One unrelated comment, can you display a verbiage on the page about the storage/usage of code that is being formatted? In other words, if you’re not saving any of the code or phoning home or using any part of it to train the tool, can you call it out, so that people formatting sensitive code know what to expect. |
2244ce8
to
426a058
Compare
Good point, I could imagine that it might even be illegal under the GDPR to send the data without explicit consent. I added this line:
|
I've had a chance to look at the new page, and here are my findings:
Input
Now, while the last line does say what the problem is, this is an exception rather than the rule as Haskell is notorious for hard-to-understand compiler errors. Column 5 happens to be the beginning of |
d9af426
to
119dcc6
Compare
426a058
to
39b33c9
Compare
Thanks, I just updated the site based on your findings with only slight deviations (ghc-lib-parser version is next to the commit link, and I left off point 3 for now, as I find it somewhat neat to be able to directly jump to the README). |
LGTM 👍 |
Just want to say that this was a great idea. I pasted the following code at https://ormolu-live.tweag.io/:
and it failed with:
However, column numbers aren't shown in the input, so, it's not immediately apparent which of the two |
23a13e2
to
3e7308c
Compare
39b33c9
to
1464810
Compare
3e7308c
to
bcc4a4c
Compare
Various re-exports got removed.
1464810
to
6d63645
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting stuff!
Should be reverted once the WASM backend supports TH. Co-authored-by: Mark Karpov <mark.karpov@tweag.io>
Co-authored-by: Mark Karpov <mark.karpov@tweag.io>
1f80df9
to
d824bc9
Compare
New Ormolu Live based on the upcoming GHC WASM backend.
Closes #951
Test deployment at https://ormolu-live-testbed.netlify.app/
Diff is severly inflated by lockfile changes.