WIP - make our methods private #28194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hzoo: do you have any idea why this fails? |
|
Yea, we either need to modify the rule or add it to scope babel/babel-eslint#746, shouldn't be too bad to fix but no one has yet |
|
I tought about that PR, and we should close it, because currently we ship Bootstrap with fake private methods which are in reality public methods, so it'll introduce a sort of breaking change. So we should tackle that in our v5 (@XhmikosR don't laugh on me 😄) Thanks @hzoo to taking a look at that PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to transform our (fake) private methods to real one
but ESLint continue to throw me errors 😟