-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add borderless table feature wrt #22638 #22799
Conversation
scss/_tables.scss
Outdated
} | ||
thead tr { | ||
td, th { | ||
border: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border: 0
is preferred over border: none
scss/_tables.scss
Outdated
} | ||
tfoot tr { | ||
td, th { | ||
border: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border: 0
is preferred over border: none
scss/_tables.scss
Outdated
.table-borderless { | ||
tbody tr { | ||
td, th { | ||
border: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border: 0
is preferred over border: none
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hound bot!
This doesn't seem like the right solution in the code. I haven't tested this, but it could probably all be reduced to something like maybe? .table-borderless {
td, th {
border: 0;
}
} All we need to do is override the default |
I guess it should work without the explicit |
Making myself a note that this needs docs for when we're ready for it. |
@Varunram: can you add the new class in our docs? |
scss/_tables.scss
Outdated
@@ -151,6 +151,11 @@ | |||
} | |||
} | |||
|
|||
.table-borderless { | |||
th,td { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected newline after "," selector-list-comma-newline-after
Expected single space after "," in a single-line list selector-list-comma-space-after
Sure, let me rebase the PR on dev and revert all redundant commits. |
6ecbdd4
to
ab093b9
Compare
@mdo: LGTY? |
Fixes #22638.
CC @mdo @Johann-S