Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add borderless table feature wrt #22638 #22799

Merged
merged 1 commit into from
Jan 20, 2018
Merged

Conversation

Varunram
Copy link
Contributor

@Varunram Varunram commented Jun 12, 2017

Fixes #22638.

CC @mdo @Johann-S

}
thead tr {
td, th {
border: none;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

border: 0 is preferred over border: none

}
tfoot tr {
td, th {
border: none;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

border: 0 is preferred over border: none

.table-borderless {
tbody tr {
td, th {
border: none;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

border: 0 is preferred over border: none

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hound bot!

@mdo
Copy link
Member

mdo commented Jun 13, 2017

This doesn't seem like the right solution in the code. I haven't tested this, but it could probably all be reduced to something like maybe?

.table-borderless {
  td, th {
    border: 0;
  }
}

All we need to do is override the default .table styles, so perhaps compare against that opening .table ruleset?

@Varunram
Copy link
Contributor Author

I guess it should work without the explicit tbodys. Thanks for the time @mdo, Updating my PR

@mdo
Copy link
Member

mdo commented Aug 5, 2017

Making myself a note that this needs docs for when we're ready for it.

@XhmikosR
Copy link
Member

@Varunram: can you add the new class in our docs?

@@ -151,6 +151,11 @@
}
}

.table-borderless {
th,td {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected newline after "," selector-list-comma-newline-after
Expected single space after "," in a single-line list selector-list-comma-space-after

@Varunram
Copy link
Contributor Author

Varunram commented Oct 10, 2017

Sure, let me rebase the PR on dev and revert all redundant commits.

@XhmikosR
Copy link
Member

@mdo: LGTY?

@XhmikosR XhmikosR requested a review from mdo October 10, 2017 22:12
@sanspace
Copy link

@mdo @cvrebert Is this to be added in a future release?

@mdo mdo mentioned this pull request Jan 20, 2018
@mdo mdo merged commit ab093b9 into twbs:v4-dev Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants