Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bootstrap masthead - Vertically center "B" #22695

Closed
wants to merge 1 commit into from
Closed

Update Bootstrap masthead - Vertically center "B" #22695

wants to merge 1 commit into from

Conversation

sandrosc
Copy link

@sandrosc sandrosc commented May 25, 2017 •
edited
Loading

This change would vertically center the B and make it look a bit better IMO.
I have included screenshots, judge for yourself.

Before:
bootstrap_before

After:
bootstrap_after

@mdo
Copy link
Member

mdo commented May 26, 2017

How's this look everywhere else? 8rem on macOS looks just as wrong. I think instead we'll want to swap this for an SVG.

@mdo mdo mentioned this pull request May 27, 2017
Merged
@mdo
Copy link
Member

mdo commented May 27, 2017

Superseded by #22708.

@mdo mdo closed this May 27, 2017
@sandrosc sandrosc deleted the patch-1 branch May 28, 2017 15:40
@sandrosc
Copy link
Author

Very cool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css docs v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandrosc @mdo @Johann-S