-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move node-sass to npm script and drop Ruby Sass. #21489
Conversation
Do we know if libsass finally achieved feature parity with sass? A comparison in output for the unminified file would be handy, I think. (Unless this has already been examined and I'm OOTL.) |
Bootstrap already uses libsass by default, so this doesn't change that. The only differences in the output between libsass and Ruby Sass are to do with how whitespace is treated (I had to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it! Looks like tests are failing for some linting issues, otherwise looks good to me!
@hnrch02 did you have any further concerns or shall we LGTM? I've fixed the linting issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like I was just out of the loop on ruby Sass 😄 LGTM!
This PR moves node-sass to a NPM script.
Per #20332, I've also dropped Ruby Sass support: