Extend ESLint to cover all JS files and drop JSCS. #21480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
|
IIRC, @cvrebert had reservations about removing semicolons in the build JS. I welcome the change though, better to keep it consistent. |
|
I was wondering about that, but at the time I was tired of wrestling with the various ESLint configs and it seemed the easiest way out. Given that we're looking at dropping the Gruntfile anyway as soon as I can get the npm scripts working correctly, I'm not going to worry too much. Do holler if I'm missing something here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17924 and fixes #20740. We have two ESLint configurations,
js/.eslintrc.json(ES6, used forjs/src/), andjs/tests/.eslintrc.json(ES5, used forjs/tests/,grunt/,docs/assets/js/src,docs/assets/js/ie-emulation-modes-warning.jsanddocs/assets/js/ie10-viewport-bug-workaround.js). As with my other linting changes, we may wish to tighten this later.