Flexbox enable list-group #18981
Flexbox enable list-group #18981
Conversation
… pull-right and pull-left flex change from PR twbs#18976
rosskevin
changed the title
| Cras justo odio | ||
| <span class="label label-default label-pill pull-right">14</span> |
There was a problem hiding this comment.
There's no pull-right class anymore. Stick with pull-xs-right
Also, won't putting the floats last instead of first cause some breakage when flexbox is disabled?
There was a problem hiding this comment.
- I'm confused about pull-right/left, because it is still there in on v4-dev tip and I'm not seeing the responsive classes. I can change that back.
- It does not appear to have any problems floating in my test (granted it may be limited testing considering I didn't go after a bunch of browsers). The fact is that
pull-rightappears to work this way in the docs for both flex and normal layouts.
I can change it back, but then we may have questions about a flexed pull-right not working too...
I'll change the pull-*-right back and commit.
There was a problem hiding this comment.
(1) There are still pull-left/right mixins, but the pull-left/right classes are gone as of #18340. I just double-checked.
(2) I'm not 100% sure either. Will ask mdo when he reviews this.
|
Any news on this? |
|
Merged, but made some changes to this with 7ba4ac0. Rather than change how our default examples are structured, I've added guidance on how to move from the default mode to the flexbox mode for the list group. |
Resolves #18978
Requires the pull-right and pull-left flex change from PR #18976
/cc @cvrebert