Print style updates #14790
Merged
Print style updates #14790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
If everyone agrees with the changes, let me know so that I squash the patches before merging this. |
|
I have no objection. |
Also, keep the html5 boilerplate link in the built CSS.
|
The indentation on the print styles file has changed from 2 spaces to 4 spaces. We'll need to fix that. |
|
This is intentional like I mention in my op. It's the upstream's file
|
|
Clearly missed that part 😁. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the link patch separately for now since I'm not sure if everyone agrees with that change. Personally, I feel like we should keep the link.
I also marked the custom Bootstrap code with a comment
// Bootstrap specific changes start/end.BTW, https://github.com/twbs/bootstrap/pull/14790/files?w=false since I kept the original file's indentation.
/CC @mdo @cvrebert @hnrch02