Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document arguments passed to placement function of tooltip/popover #14264

Merged
merged 1 commit into from
Jul 29, 2014

Conversation

hnrch02
Copy link
Collaborator

@hnrch02 hnrch02 commented Jul 28, 2014

Closes #14255

Not to sure about the phrasing. Also, commas in English are weird 😄

/cc @cvrebert

@cvrebert
Copy link
Collaborator

Perhaps use <p>s instead of <br>s

@hnrch02
Copy link
Collaborator Author

hnrch02 commented Jul 28, 2014

Good call. Also fixed a few lines with wrong indentation.

@cvrebert
Copy link
Collaborator

@hnrch02 The reindentation changes and my merging of some other PRs has caused this to have merge conflicts. Can you update this PR? Thanks!

@cvrebert cvrebert added the docs label Jul 28, 2014
@cvrebert cvrebert added this to the v3.2.1 milestone Jul 28, 2014
@hnrch02
Copy link
Collaborator Author

hnrch02 commented Jul 29, 2014

Rebased.

<td>'top'</td>
<td>
<p>How to position the tooltip - top | bottom | left | right | auto.<br>When "auto" is specified, it will dynamically reorient the tooltip. For example, if placement is "auto left", the tooltip will display to the left when possible, otherwise it will display right.</p>
<p>When a function is used to determine the placement, it is called with the tooltip DOM node as its first argument and the triggering element DOM node as its second. The <code>this</code> context is set to the tooltip instance.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra space between the words "context" and "is"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

cvrebert added a commit that referenced this pull request Jul 29, 2014
Document arguments passed to `placement` function of tooltip/popover
@cvrebert cvrebert merged commit fc1db2e into twbs:master Jul 29, 2014
@hnrch02 hnrch02 deleted the document-placement-args branch July 29, 2014 00:48
@cvrebert cvrebert mentioned this pull request Jul 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document arguments passed to tooltip/popover placement function
2 participants