Increase default authentication timeout #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings it more in line with the Java client and librdkafka. The configuration values for those clients are a bit different, where a single configuration value is used as a "total timeout for socket establishment", instead of having one configuration value for TCP socket connection and one for authentication. KIP-601 goes into this in more detail. This change does not make KafkaJS work the same way, but it does set the default to a more sane value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java client and librdkafka have a single timeout configuration value for connection establishment, which includes the entire operation of TCP socket connection, protocol negotiation and authentication. However, they work slightly differently:
2 * connectionTimeout + authenticationTimeout, whereauthenticationTimeoutis 1s. This means that in practice our equivalent timeout is 3 seconds. This PR changes that to effectively be 12 seconds, bringing it more in line with the other clients.I considered going full librdkafka and setting it to 30 seconds, but it's much easier to increase defaults than to decrease them if we want to change things in the future. Just setting the authentication timeout to 10s is probably going to solve most people's issues regardless.
Relates to #1332