MAN-1373 Trap when image fails to attach to event #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also now uses guid rather than hash to pick up any change from the feed on exisiting events
cdoyle-temple
force-pushed
the
MAN-1373-Event_feed_not_updating-Attached_image
branch
from
6af8f04 to
762b971
Compare
sensei100
approved these changes
Sep 13, 2024
sensei100
deleted the
MAN-1373-Event_feed_not_updating-Attached_image
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major portion of this solution is that an event that receives the forbidden error message for an image from the university server will now still update the event. This was not how the code was previously setup. There is some refactoring of the sync code to enable this.
Any image error will now be temporarily recorded to cache and the associated event title will be displayed to the user initializing the manual sync for further review. Automatic syncs are no longer enabled, from previous work.