Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add portName to 'storeReady' message #253

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

sokki
Copy link
Contributor

@sokki sokki commented Jun 18, 2020

First of all: thank you so much for this library ❤️

We have multiple redux stores that we want to sync. That works mostly great with the portName parameter. But we run into race conditions regarding the storeReady message: Whatever store is ready first, triggers a storeReady for all stores because the storeReady did not take the portName into consideration.

Copy link
Owner

@tshaddix tshaddix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad this library is adding value to your projects!

This PR looks great! Thank you very much for contributing! Really appreciate the work you've done here (especially the tests!)

@tshaddix tshaddix merged commit 9c61f3f into tshaddix:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants