Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracing-subscriber to v0.3.17 #535

Closed
wants to merge 2 commits into from

Conversation

s1gtrap
Copy link
Contributor

@s1gtrap s1gtrap commented Apr 22, 2023

Simply bump tracing-subscriber to latest v0.3.17.

Fixes #534, resolved by tokio-rs/tracing#2566.

Not sure if any of the checkpoints apply for such a minor change?

Copy link
Member

@thedodd thedodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that you actually just do cargo update, and then verify that a sufficient version has been pinned in the lock file. Let's not update the Cargo.toml itself in this case.

@s1gtrap s1gtrap force-pushed the bump-tracing-subscriber branch from 9d74e5e to e6b50f0 Compare April 25, 2023 17:18
@s1gtrap
Copy link
Contributor Author

s1gtrap commented Apr 25, 2023

I would prefer that you actually just do cargo update, and then verify that a sufficient version has been pinned in the lock file. Let's not update the Cargo.toml itself in this case.

Interesting, why is that exactly? I assume cargo update changes the locked version to the latest? But I just ran it as you said and amended my branch.

@s1gtrap s1gtrap force-pushed the bump-tracing-subscriber branch from 35731eb to a8976d3 Compare June 4, 2023 17:51
@s1gtrap
Copy link
Contributor Author

s1gtrap commented Jun 4, 2023

I forgot to push the changes beck then, but I rebased it on master and pushed it just now. Thought I'm not sure how relevant it is at this point.. @thedodd

@thedodd
Copy link
Member

thedodd commented Jul 7, 2023

I don't think that this PR is needed any longer.

@thedodd thedodd closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal regex parse error coming from tracing-subscriber after updating
2 participants