This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
chore: add pr template #3970
Closed
chore: add pr template #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsmale90
reviewed
Nov 30, 2022
tenthirtyone
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
👍
I usually see two different types of PR template. This kind and a 'preflgiht pr checklist' is how I think of the 2nd.
https://github.com/devspace/awesome-github-templates
I like these a lot for starting a funnel before we triage issues, too, if it works out for PRs.
|
I've rearranged a bit and added some further comments to make very clear that most of the information is optional for external contributors. @davidmurdoch's concern is that these templates will be a barrier to entry or an annoyance for some contributors, and we definitely don't want that. Input welcome. |
tenthirtyone
approved these changes
Dec 8, 2022
|
I don't like it :-/ |
|
Seems like this isn't something we think is best for us right now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR introduces a PR template that will be used to guide contributors on a format for creating PRs in the Ganache repo. Fixes #3758
We can bike shed this to our heart's content, but I figured I'd get something out to start the conversation. By the way, this PR description uses the template.
Testing instructions
N/A
Documentation
doc-change-requiredlabel to this PR so that documentation can be added by the docs team in another PR.README.md.CONTRIBUTING.md.src/chains/ethereum/ethereum/RPC-METHODS.md.src/chains/ethereum/ethereum/src/api.ts.Release Notes
This change introduces a PR template that will be used to guide contributors on a format for creating PRs in the Ganache repo.