Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pd 1257 backup to google photos must select albums as destination folder #2893

Merged
merged 35 commits into from
Jul 18, 2024
Merged

Pd 1257 backup to google photos must select albums as destination folder #2893

merged 35 commits into from
Jul 18, 2024

Conversation

DjP-iX
Copy link
Contributor

@DjP-iX DjP-iX commented Jul 11, 2024

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

DjP-iX added 26 commits July 8, 2024 15:31
@DjP-iX
Update AddGooglePhotosCloudSyncTask.md
f2c6bec
@DjP-iX
Update GooglePhotosAPIAddTestingUser.png
0b50cb6
@DjP-iX
Update GooglePhotosAPIAppInformation.png
f6bc20e
@DjP-iX
Update GooglePhotosAPIClickEnable.png
cf57487
@DjP-iX
Update GooglePhotosAPICreateExternal.png
1b751c9
@DjP-iX
Update GooglePhotosAPIDeveloperContactInformation.png
555555f
@DjP-iX
Update GooglePhotosAPIEnableAPIsandServices.png
e2cb8eb
@DjP-iX
Update GooglePhotosAPINewProject.png
6579741
@DjP-iX
Delete GooglePhotosAPIPhotosLibraryAPISearch.png
bdc00f1
@DjP-iX
Update GooglePhotosAPIPublish.png
089542a
@DjP-iX
Update AddGooglePhotosCloudSyncTask.md
1ee6def
@DjP-iX
Update CloudSyncTaskWizardProviderScreen.png
7a85ae6
@DjP-iX
Update CloudSyncTaskWizardWhatandWhenScreen.png
1a6f737
@DjP-iX
Update GooglePhotosAPIAddCloudCredentials.png
d639bad
@DjP-iX
Update GooglePhotosAPIAddCredentials.png
5c57589
@DjP-iX
Update GooglePhotosAPICopyIDandSecret.png
f3a4bd2
@DjP-iX
Update GooglePhotosAPICreateOAuthClientID.png
a26277b
@DjP-iX
Update GooglePhotosAPIrcloneConfig.png
80ac94d
@DjP-iX
Update GooglePhotosAPIrcloneConfig2.png
4949ef2
@DjP-iX
Update GooglePhotosAPIrcloneConfig3.png
dd63376
@DjP-iX
Update CreateCloudSyncTaskScale.md
9642e9a
@DjP-iX
Update AddGooglePhotosCloudSyncTask.md
af85e9c
@DjP-iX
Update CloudSyncTasksScreensSCALE.md
2c350c5
@DjP-iX
Update AddGooglePhotosCloudSyncTask.md
46d94a1
@DjP-iX
Update AddGooglePhotosCloudSyncTask.md
4e582f9
@DjP-iX
Update AddGooglePhotosCloudSyncTask.md
fa084e3
@DjP-iX DjP-iX requested a review from a team as a code owner July 11, 2024 18:50
micjohnson777
micjohnson777 requested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@micjohnson777 micjohnson777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's chat if my comments don't make sense.

@micjohnson777 micjohnson777 added the Technical Writer Review (MJ) A technical writer is reviewing the PR. label Jul 15, 2024
DjP-iX and others added 2 commits July 15, 2024 10:36
@DjP-iX
Update AddGooglePhotosCloudSyncTask.md
56bd248
@DjP-iX @micjohnson777
Update static/includes/CreateCloudSyncTaskScale.md
c52cda8 
Co-authored-by: MicJ <92740932+micjohnson777@users.noreply.github.com>
@DjP-iX DjP-iX requested a review from micjohnson777 July 15, 2024 14:38
micjohnson777
micjohnson777 requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@micjohnson777 micjohnson777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tweaks/suggested changes then it is good to go!
Again, excellent content only needs a minor adjustments

DjP-iX and others added 4 commits July 18, 2024 10:18
@DjP-iX @micjohnson777
Apply suggestions from code review
7a1af87 
Co-authored-by: MicJ <92740932+micjohnson777@users.noreply.github.com>
@micjohnson777 @DjP-iX
Update content/SCALE/SCALETutorials/DataProtection/CloudSyncTasks/Add…
e4cde59 
…GooglePhotosCloudSyncTask.md

Co-authored-by: DjP-iX <133042991+DjP-iX@users.noreply.github.com>
@micjohnson777
Update AddGooglePhotosCloudSyncTask.md
d1695a3 
Remove "Next" from line 68
@micjohnson777
Merge branch 'master' into PD-1257-backup-to-google-photos-must-selec…
b0131a8 
…t-albums-as-destination-folder
@micjohnson777 micjohnson777 merged commit 106447a into master Jul 18, 2024
3 checks passed
@micjohnson777 micjohnson777 deleted the PD-1257-backup-to-google-photos-must-select-albums-as-destination-folder branch July 18, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micjohnson777 micjohnson777 micjohnson777 approved these changes

Assignees
No one assigned
Labels
Technical Writer Review (MJ) A technical writer is reviewing the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DjP-iX @micjohnson777