feat(terraform): add support for using existing GKE clusters #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new variable `use_existing_cluster` to toggle between creating a new GKE cluster or using an existing one. Update resources and outputs to conditionally reference existing cluster data when enabled. Add a migration script and upgrade guide for transitioning from version 0.3.x to 0.4.x, ensuring a smooth upgrade process. Enhance variable descriptions for clarity and improve documentation.
dunefro
requested changes
Nov 26, 2024
Introduce `use_existing_cluster` variable to conditionally create resources, allowing flexibility in using existing clusters. Update firewall rules and node pool configurations to respect this setting. Enhance variable descriptions with defaults for clarity and improve resource tagging and filtering capabilities.
…nt cluster ID usage fix(gke.tf): adjust firewall rule count logic to account for shared VPC with existing cluster
…lete script Remove placeholder migration script for 0.4.x as it is no longer needed. Update upgrade guide to include new `use_existing_cluster` variable and instructions for using `terraform state mv` for resource migration.
dunefro
reviewed
Nov 28, 2024
dunefro
reviewed
Nov 28, 2024
…r clarity refactor(variables.tf): reorder variables for better logical grouping and readability
dunefro
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new variable
use_existing_clusterto toggle betweencreating a new GKE cluster or using an existing one. Update resources
and outputs to conditionally reference existing cluster data when
enabled. Add a migration script and upgrade guide for transitioning
from version 0.3.x to 0.4.x, ensuring a smooth upgrade process. Enhance
variable descriptions for clarity and improve documentation.