*: add Docker build environment #24
Conversation
| RUN go mod download && go mod verify | ||
|
|
||
| # Then copy sources and compile project | ||
| COPY . . |
There was a problem hiding this comment.
This feels a bit wonky but I guess just copying all the things does no real harm either
| # Compile metric export plugin | ||
| WORKDIR /usr/src/ipfs/metric-export-plugin | ||
| # Get and compile dependencies first, since we can cache those. | ||
| COPY go.mod go.sum ./ |
There was a problem hiding this comment.
Not a big deal at the moment but just for completntess sake: This means that a new image is created everytime the code changes and the CI is executed, correct?
Maybe just having go-ipfs with a fixed tag inside the container and simply mounting the plugin source would be more efficient?
|
Some dependency of the format checker is broken, I'll try to re-run the CI and merge in a few days... |
|
Ah, turns out this is because we use Go 1.16, and the latest version of We cannot build with Go 1.17 due to the linker bugs with plugins. As a temporary workaround I'll fix the version of |
I'm not 100% sure if it's worth executing the builder stage in CI every time.
I guess it's fine -- the more things we test continuously, the better.
At some point in the future we could make these available somehow...
This depends on #23